-
Notifications
You must be signed in to change notification settings - Fork 998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gles): support gles backend on openharmony #7085
Conversation
Did you at least test this locally? I'm hesitant to include support if it's been completely untested. |
Sure, i test it with wgpu-template and change to the following code: // graphics.rs
pub async fn create_graphics() {
// old
// let instance = Instance::default();
let wids = wgpu::InstanceDescriptor {
backends: wgpu::Backends::GL,
flags: Default::default(),
backend_options: Default::default()
};
let instance = Instance::new(&wids); You can see the source code with wgpu-demo-with-winit And vulkan mode need to update the latest ash version see detail ash-rs/ash#983 |
how hard would it be to add a (build-only) ci test for this target? If that's just another rust toolchain to include that should be definitely done, otherwise it's just a question of time when this breaks again |
Even if it's tier3, we already have a tier3 path in CI, so shouldn't be that bad |
Right, i will add it. But when i use this patch to test examples with wgpu-in-app, |
Don't feel pressured to fix those first. We can land support one step at a time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Connections
Link to the issues addressed by this PR, or dependent PRs in other repositories
Description
Support
gles
render for OpenHarmony.Testing
There isn't a public openharmony emulator to run test. So we can't run test.
Checklist
cargo fmt
.taplo format
.cargo clippy
. If applicable, add:--target wasm32-unknown-unknown
cargo xtask test
to run tests.CHANGELOG.md
. See simple instructions inside file.